Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workspace]Hide saved object import button when user is outside workspace #7989

Merged
merged 2 commits into from
Sep 5, 2024
Merged

[Workspace]Hide saved object import button when user is outside workspace #7989

merged 2 commits into from
Sep 5, 2024

Conversation

yubonluo
Copy link
Contributor

@yubonluo yubonluo commented Sep 4, 2024 •
edited
Loading

Description

Hide saved object import button in the save object management page(assets page)when user is outside workspace.

Issues Resolved

Related issue #4944

Screenshot

outside workspace
image
inside a workspace
image

Testing the changes

Changelog

  • refactor: Hide saved object import button when user is outside workspace

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yubonluo
Hide saved object import button when user is outside workpace
ea44d25 
Signed-off-by: yubonluo <yubonluo@amazon.com>
@codecov Codecov
Copy link

codecov bot commented Sep 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.09%. Comparing base (7dedc58) to head (ab6f942).
Report is 97 commits behind head on main.

Files with missing lines Patch % Lines
...gement_section/objects_table/components/header.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7989   +/-   ##
=======================================
  Coverage   61.09%   61.09%           
=======================================
  Files        3691     3691           
  Lines       87310    87313    +3     
  Branches    13433    13436    +3     
=======================================
+ Hits        53340    53343    +3     
  Misses      30722    30722           
  Partials     3248     3248
Flag Coverage Δ
Linux_1 29.32% <0.00%> (-0.01%) ⬇️
Linux_2 56.24% <ø> (ø)
Linux_3 37.93% <0.00%> (-0.01%) ⬇️
Linux_4 29.59% <66.66%> (+<0.01%) ⬆️
Windows_1 29.34% <0.00%> (-0.01%) ⬇️
Windows_2 56.19% <ø> (ø)
Windows_3 37.93% <0.00%> (-0.01%) ⬇️
Windows_4 29.59% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanyl ruanyl merged commit 35be041 into opensearch-project:main Sep 5, 2024
74 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 5, 2024
@github-actions @opensearch-changeset-bot
[Workspace]Hide saved object import button when user is outside works…
7fe2acd 
…pace (#7989)

* Hide saved object import button when user is outside workpace

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR #7989 created/updated

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 35be041)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 5, 2024
Merged
SuZhou-Joe pushed a commit that referenced this pull request Sep 5, 2024
@opensearch-trigger-bot @github-actions
@opensearch-changeset-bot @ruanyl
[Workspace]Hide saved object import button when user is outside works…
81ccf48 
…pace (#7989) (#8014)

* Hide saved object import button when user is outside workpace



* Changeset file for PR #7989 created/updated

---------



(cherry picked from commit 35be041)

Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 6, 2024
@github-actions @opensearch-changeset-bot @ruanyl
[Workspace]Hide saved object import button when user is outside works…
b737f60 
…pace (#7989) (#8014)

* Hide saved object import button when user is outside workpace

* Changeset file for PR #7989 created/updated

---------

(cherry picked from commit 35be041)

Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
(cherry picked from commit 81ccf48)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Sep 6, 2024
@opensearch-trigger-bot @github-actions
@opensearch-changeset-bot @ruanyl
[Workspace]Hide saved object import button when user is outside works…
c29810a 
…pace (#7989) (#8014) (#8041)

* Hide saved object import button when user is outside workpace

* Changeset file for PR #7989 created/updated

---------

(cherry picked from commit 35be041)






(cherry picked from commit 81ccf48)

Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ruanyl ruanyl ruanyl approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

Assignees
No one assigned
Labels
all-star-contributor backport 2.x in-next v2.17.0 workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yubonluo @ruanyl @SuZhou-Joe @AMoo-Miki